Check-in [dd737cd8c7]
Overview
Comment:Fixed NULL pointer dereference and also possible buffer overflow processing HTTP request, created in [8cb189c633]
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1: dd737cd8c71ffeda779fd947a385fcc8213a6dd4
User & Date: rkeene on 2014-02-12 17:42:15
Other Links: manifest | tags
Context
2014-02-12
17:56
Filed 1.6 check-in: f7cedf8636 user: rkeene tags: trunk, 1.6
17:42
Fixed NULL pointer dereference and also possible buffer overflow processing HTTP request, created in [8cb189c633] check-in: dd737cd8c7 user: rkeene tags: trunk
06:11
Updated to use time to ensure that a duplicate ETag is never generated check-in: 7e211d072e user: rkeene tags: trunk
Changes

Modified filed.c from [ba4c14a79b] to [64aa094753].

678
679
680
681
682
683
684



685
686
687
688
689
690
691
	} else {
		/* HEAD request */
		buffer_st->method = FILED_REQUEST_METHOD_HEAD;
	}

	/* Note path */
	strcpy(buffer_st->path, path);




	for (i = 0; i < 100; i++) {
		fgets_ret = fgets(buffer, buffer_len, fp);
		if (fgets_ret == NULL) {
			break;
		}








>
>
>







678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
	} else {
		/* HEAD request */
		buffer_st->method = FILED_REQUEST_METHOD_HEAD;
	}

	/* Note path */
	strcpy(buffer_st->path, path);

	/* Reset buffer for later use */
	buffer = buffer_st->tmpbuf;

	for (i = 0; i < 100; i++) {
		fgets_ret = fgets(buffer, buffer_len, fp);
		if (fgets_ret == NULL) {
			break;
		}